Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: identifierBase parameter for .inc #532

Merged
merged 1 commit into from
Apr 10, 2023
Merged

feat: identifierBase parameter for .inc #532

merged 1 commit into from
Apr 10, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Apr 5, 2023 •
edited

Cleanup of #249
Closes #245

Authored by @b-bly

@wraithgar wraithgar requested a review from a team as a code owner April 5, 2023 23:14
@wraithgar wraithgar requested review from fritzy and removed request for a team April 5, 2023 23:14
@wraithgar wraithgar requested review from lukekarrys and removed request for fritzy April 5, 2023 23:23
@wraithgar wraithgar mentioned this pull request Apr 5, 2023
Closed
nlf
nlf approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes a lot of sense too, lgtm

@wraithgar wraithgar merged commit 113f513 into main Apr 10, 2023
25 checks passed
@wraithgar wraithgar deleted the pull/249 branch April 10, 2023 16:21
@github-actions github-actions bot mentioned this pull request Apr 10, 2023
Merged
@lsvalina lsvalina mentioned this pull request Apr 12, 2023
Merged
@ms-bot ms-bot mentioned this pull request Apr 17, 2023
Draft
@snyk-bot snyk-bot mentioned this pull request May 16, 2023
Open
This was referenced Jul 31, 2023
Closed
Closed
Closed
This was referenced May 24, 2024
Open
Open
This was referenced May 26, 2024
Open
Open
@claude-morningstar47 claude-morningstar47 mentioned this pull request May 28, 2024
Open
@devcurt696 devcurt696 mentioned this pull request May 29, 2024
Open
@dopeeycode dopeeycode mentioned this pull request May 29, 2024
Open
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

@lukekarrys lukekarrys Awaiting requested review from lukekarrys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] method .inc - option to set prerelease identifier numbering to be zero-based or one-based
3 participants
@wraithgar @nlf @b-bly